Timestamps are in GMT/BST.
| 00:28:00 | | raptor has joined |
| 00:28:00 | | ChanServ sets mode +o raptor |
| 00:29:00 | raptor | down came the rain and washed the spider out.. |
| 00:40:00 | | raptor Quit (Remote host closed the connection) |
| 01:30:00 | | watusimoto Quit (Ping timeout: 240 seconds) |
| 02:23:00 | | watusimoto has joined |
| 02:35:00 | | watusimoto Quit (Ping timeout: 252 seconds) |
| 03:48:00 | | watusimoto has joined |
| 04:17:00 | | raptor has joined |
| 04:17:00 | | ChanServ sets mode +o raptor |
| 04:25:00 | | [1]watusimoto has joined |
| 04:27:00 | | watusimoto Quit (Ping timeout: 276 seconds) |
| 04:27:00 | | [1]watusimoto is now known as watusimoto |
| 04:36:00 | | [1]watusimoto has joined |
| 04:37:00 | raptor | well, i can't seem to upgrade my windows 7 system to SP1 because I have linux on the same machine and the service pack fails with a partition warning |
| 04:37:00 | raptor | how goofy is that |
| 04:38:00 | sam686 | maybe your virtual machine are buggy? |
| 04:38:00 | sam686 | if you are using it.. |
| 04:38:00 | raptor | this is actually a dool boot machine |
| 04:38:00 | raptor | i boot into windows 7 |
| 04:38:00 | sam686 | ok.. |
| 04:38:00 | raptor | no VMs involved |
| 04:38:00 | raptor | oh well |
| 04:39:00 | | watusimoto Quit (Ping timeout: 258 seconds) |
| 04:39:00 | | [1]watusimoto is now known as watusimoto |
| 04:41:00 | raptor | nothing like good old Mozart to get me into the mood to code... |
| 04:59:00 | | [1]sam686 has joined |
| 05:01:00 | | sam686 Quit (Ping timeout: 258 seconds) |
| 05:01:00 | | [1]sam686 is now known as sam686 |
| 05:07:00 | raptor | watusimoto: i got linux to compile again |
| 05:09:00 | raptor | wow, no walls when hosting in-game.. |
| 05:09:00 | raptor | Unknown object type "BarrierMaker" in level "ctf1.level" |
| 05:09:00 | raptor | haha |
| 05:11:00 | watusimoto | yup |
| 05:11:00 | watusimoto | I'm getting that too |
| 05:12:00 | raptor | looks like it's because BarrierMaker is the only object not named the same as the class.. |
| 05:12:00 | raptor | cool |
| 05:12:00 | watusimoto | I'm checking in another big batch of fun |
| 05:12:00 | raptor | well, i kind of want to check in my linux fixes... |
| 05:13:00 | watusimoto | won't fix anything, but does remove reliance on mGameObjects and gBotNavZones |
| 05:13:00 | raptor | cool |
| 05:13:00 | watusimoto | now those two lists are maintained by the database |
| 05:13:00 | watusimoto | there is a similar list in the editor (mEditorObjects?) that can be handled the same way |
| 05:13:00 | watusimoto | that will clarify ownership as we migrate to shared_ptr |
| 05:14:00 | watusimoto | should I hold off checking in until you do your linux stuff |
| 05:14:00 | watusimoto | ? |
| 05:15:00 | raptor | no... i ran into problems |
| 05:15:00 | raptor | using shared_ptr instead of pointainer opened pandora's box |
| 05:15:00 | raptor | again |
| 05:16:00 | raptor | it's these two mehtods: EditorObject::addToDock EditorObject::addToEditor |
| 05:16:00 | watusimoto | did you first go back to Vector? |
| 05:16:00 | raptor | because they act on themselves (the EditorObject) with 'this' |
| 05:16:00 | watusimoto | ok; what did you make into a shared_ptr? |
| 05:16:00 | raptor | problem is that sometimes EditorObject is a pointer*, othertimes it's a shared_ptr |
| 05:17:00 | raptor | anything with pointainers |
| 05:17:00 | watusimoto | my current thought is that it should be a shared_ptr in the database, but outside should just be a pointer |
| 05:17:00 | sam686 | try this.getPointer() oe this->getPointer() or similar? |
| 05:17:00 | watusimoto | most functions go to the database, grab some pointers, do some stuff, then move on |
| 05:18:00 | watusimoto | those pointers become stale when the function exits, and we don't try to use them again |
| 05:18:00 | watusimoto | we don't need smart pointers for that use case |
| 05:18:00 | raptor | sam686: that is not the problem: the problem is that sometimes that function is called on the object when it's a pointer, othertimes when it's a shared_ptr |
| 05:19:00 | watusimoto | ok mDockItems should be a shared_ptr |
| 05:19:00 | raptor | yep |
| 05:19:00 | raptor | Vector<boost::shared_ptr<EditorObject> > mDockItems; |
| 05:19:00 | watusimoto | mItems is going away; don't worry about that one |
| 05:19:00 | raptor | and Vector<boost::shared_ptr<EditorObject> > mItems; |
| 05:19:00 | raptor | oh ok |
| 05:20:00 | watusimoto | that can just be Vector<EditorObject *> |
| 05:20:00 | raptor | which one? |
| 05:20:00 | raptor | oh, mDockItems? |
| 05:20:00 | watusimoto | Items |
| 05:21:00 | watusimoto | mItems |
| 05:21:00 | raptor | ok |
| 05:21:00 | watusimoto | then that will be refactored out |
| 05:21:00 | watusimoto | so it's only a stopgap to get rid of pointainer |
| 05:21:00 | watusimoto | and mLevelGenItems shoudl eb a shared_ptr as well, but that one is probably easy |
| 05:22:00 | watusimoto | In fact, you can get rid of mItems right now if you want |
| 05:22:00 | raptor | there's 281 references in UIEditor.. |
| 05:22:00 | watusimoto | many of them will be in the same function |
| 05:23:00 | watusimoto | well, no matter; I can do it in an hour |
| 05:23:00 | raptor | can you push what you have? |
| 05:23:00 | watusimoto | yes |
| 05:24:00 | watusimoto | pushed |
| 05:25:00 | raptor | ok, here goes my rebase... |
| 05:25:00 | watusimoto | mItems is going to be mroe complex |
| 05:25:00 | watusimoto | than I thought |
| 05:26:00 | raptor | oh yeah |
| 05:26:00 | raptor | that's why i was hesitant.. |
| 05:26:00 | watusimoto | because of undo/redo |
| 05:27:00 | raptor | wow, rebased cleanly.. |
| 05:27:00 | | BitfighterLogBot - Commit 5c98f1f44ac2 | Author: watusim...@bitfighter.org | Log: Remove some of the object lists; rely on database more |
| 05:29:00 | raptor | addToDock still fails because of using shared_ptr and 'this' |
| 05:34:00 | watusimoto | you sent me a link earlier today that explained how to deal with that, no? |
| 05:35:00 | watusimoto | let hdr = msgHdrs.queryElementAt(index, Ci.nsIMsgDBHdr); |
| 05:35:00 | watusimoto | hdr.subject = "[Hello, world] " + hdr.subject; |
| 05:35:00 | watusimoto | oops bad paste |
| 05:35:00 | raptor | yeah, it uses shared_from_this() |
| 05:35:00 | watusimoto | gEditorUserInterface.mDockItems.push_back(this); |
| 05:35:00 | raptor | that's the problem line, yep |
| 05:36:00 | raptor | i'd have to include the boost header enabled_shared_from_this.hpp |
| 05:36:00 | watusimoto | in this case, you could create a function in gEUI that takes a regular pointer, wraps it in a shared_ptr, then adds it to mDockItems |
| 05:36:00 | watusimoto | it doesn't need to be a shared ptr until it gets added to mDockItems |
| 05:37:00 | watusimoto | in fact, that would be better, because mDockItems should really be private |
| 05:37:00 | watusimoto | so... |
| 05:37:00 | raptor | i'm not following very well.. |
| 05:37:00 | watusimoto | gEUI.addToDock(this); |
| 05:37:00 | watusimoto | void addToDock(EditorObject *obj){ |
| 05:37:00 | raptor | so alter the method sig |
| 05:38:00 | watusimoto | mDockItems.push_back(shared_ptr(obj)) |
| 05:38:00 | watusimoto | } |
| 05:38:00 | watusimoto | or somethiung |
| 05:38:00 | watusimoto | then make mDockItems private |
| 05:40:00 | raptor | so move the addToDock method elsewhere? |
| 05:40:00 | raptor | to UIEditor |
| 05:40:00 | raptor | that would work, i think |
| 05:41:00 | watusimoto | ah, not necessarily... you would leave that in place, but instead of accessing mDockItems directly, you'd use this new method to add it to mDockItems |
| 05:42:00 | watusimoto | void EditorObject::addToDock(Game *game, const Point &point) |
| 05:42:00 | watusimoto | { |
| 05:42:00 | watusimoto | mGame = game; |
| 05:42:00 | watusimoto | mDockItem = true; |
| 05:42:00 | watusimoto | |
| 05:42:00 | watusimoto | unselectVerts(); |
| 05:42:00 | watusimoto | gEditorUserInterface.addToDock(this); |
| 05:42:00 | watusimoto | } |
| 05:42:00 | raptor | ah ok |
| 05:42:00 | raptor | then you'd put that new method in UIEditor.cpp |
| 05:43:00 | watusimoto | yes |
| 05:43:00 | watusimoto | then no more "this" problem |
| 05:44:00 | raptor | there is already this method: EditorUserInterface::addDockObject |
| 05:46:00 | watusimoto | but that calls addToDock() |
| 05:46:00 | watusimoto | on the object |
| 05:46:00 | raptor | ha! |
| 05:46:00 | raptor | ok |
| 05:46:00 | raptor | i think i almost got it.. |
| 05:46:00 | watusimoto | think of the new function as a putter for managing mDockItems |
| 05:46:00 | watusimoto | or rather managing access to what should be a private member |
| 05:47:00 | watusimoto | though |
| 05:48:00 | raptor | good that part is solved |
| 05:48:00 | watusimoto | I don't like that it relies on a global variable (gEUI), especially when it's called from EUI itself... |
| 05:48:00 | raptor | ok, a bit more clean-up needed, then i can check in the pointainer removal.. |
| 05:48:00 | watusimoto | ok |
| 05:58:00 | raptor | so close... |
| 05:58:00 | raptor | mLoadTarget |
| 06:00:00 | raptor | switches between mItems which is EditorObject* and mLevelGenItems which is shared_ptr<EditorObject> |
| 06:09:00 | raptor | it compiles! |
| 06:09:00 | raptor | have you gotten far with your changes? |
| 06:10:00 | watusimoto | no; was working on soemthing else... did get rid of a few instances of mItems though |
| 06:11:00 | watusimoto | do you want me to press ahead with that? |
| 06:11:00 | raptor | hmmm, is it worth it to check in then? |
| 06:11:00 | watusimoto | I could... |
| 06:11:00 | watusimoto | or you could |
| 06:11:00 | raptor | i kinda want to but there are still errors of course.. |
| 06:11:00 | watusimoto | I see |
| 06:12:00 | watusimoto | what do you mean by mLoadTarget "switches"? |
| 06:12:00 | raptor | i fixed that |
| 06:12:00 | raptor | it was a pointer to a vector |
| 06:12:00 | watusimoto | ah |
| 06:12:00 | raptor | but one object was a vector of shared_ptr, the other was * |
| 06:14:00 | raptor | oh man, it crashes everywhere when accessing the grid database.. |
| 06:14:00 | watusimoto | removing mItems will actually be big |
| 06:14:00 | raptor | that's weird |
| 06:14:00 | watusimoto | what sort of crash? |
| 06:14:00 | raptor | Program received signal SIGSEGV, Segmentation fault. |
| 06:14:00 | raptor | 0x000000000045de0a in std::vector<Zap::DatabaseObject*, std::allocator<Zap::DatabaseObject*> >::size (this=0x8a0) at /usr/include/c++/4.5/bits/stl_vector.h:534 |
| 06:14:00 | raptor | 534 { return size_type(this->_M_impl._M_finish - this->_M_impl._M_start); } |
| 06:14:00 | raptor | (gdb) bt |
| 06:14:00 | raptor | #0 0x000000000045de0a in std::vector<Zap::DatabaseObject*, std::allocator<Zap::DatabaseObject*> >::size (this=0x8a0) at /usr/include/c++/4.5/bits/stl_vector.h:534 |
| 06:15:00 | raptor | #1 0x000000000045d242 in TNL::Vector<Zap::DatabaseObject*>::size (this=0x8a0) at ../tnl/tnlVector.h:251 |
| 06:15:00 | raptor | #2 0x00000000004fe304 in Zap::GridDatabase::getObjectCount (this=0x898) at gridDB.h:133 |
| 06:15:00 | raptor | #3 0x00000000005efdd3 in Zap::BotNavMeshZone::BotNavMeshZone (this=0xe84df0, __in_chrg=<value optimized out>, __vtt_parm=<value optimized out>) at BotNavMeshZone.cpp:70 |
| 06:15:00 | raptor | #4 0x00000000005f1ddc in Zap::BotNavMeshZone::buildBotMeshZones (game=0xe87210) at BotNavMeshZone.cpp:584 |
| 06:15:00 | raptor | #5 0x00000000004f8cf4 in Zap::ServerGame::cycleLevel (this=0xe87210, nextLevel=0) at game.cpp:994 |
| 06:15:00 | raptor | looks completely unrelated to my editor changes |
| 06:18:00 | watusimoto | it may be |
| 06:18:00 | raptor | happens when I host a game |
| 06:18:00 | raptor | in or out of the editor |
| 06:19:00 | raptor | i had to end up making mItems a Vector<shared_ptr<EditorObject> > for now |
| 06:19:00 | raptor | i would like to check in what I have before you get too deep with mItems removal |
| 06:19:00 | raptor | but this crash occured.. |
| 06:28:00 | raptor | ok |
| 06:28:00 | raptor | i'm going to check in |
| 06:28:00 | raptor | because I can't see how my changes are tied to the crash yet |
| 06:28:00 | raptor | and if you're removing mItems, then it would be good for these changes to get in sooner rather than later |
| 06:30:00 | raptor | ok pushed |
| 06:31:00 | raptor | i need to get to bed, good night |
| 06:32:00 | | BitfighterLogBot - Commit 11e94522bc33 | Author: buckyballreaction | Log: Compiles in Linux! But crashes still.. - remove Pointainer - fix lots of minor compiler warnings/linker errors - add a couple methods addToDock() and addToEditor() to play nicely with shared_ptr |
| 06:33:00 | watusimoto | night |
| 06:34:00 | | raptor Quit (Remote host closed the connection) |
| 08:17:00 | | kodax has joined |
| 08:43:00 | | BitfighterLogBot - Commit e463f6c38010 | Author: watusim...@bitfighter.org | Log: 1) Fix spurious warnings in editor 2) All editor drawing done from database rather than mItems 3) removed mItems from some functions |
| 08:43:00 | | BitfighterLogBot - Commit 285ffc214a27 | Author: watusim...@bitfighter.org | Log: Merge |
| 08:43:00 | | BitfighterLogBot - Commit a0cbbd980145 | Author: watusim...@bitfighter.org | Log: Don't like all the required boost:: prefixes |
| 09:03:00 | | watusimoto Quit (Ping timeout: 276 seconds) |
| 09:04:00 | | kodax Quit (Remote host closed the connection) |
| 11:44:00 | | kodax has joined |
| 13:22:00 | | kodax Quit (Remote host closed the connection) |
| 14:08:00 | | raptor has joined |
| 14:08:00 | | ChanServ sets mode +o raptor |
| 14:18:00 | | BitfighterLogBot - Commit d43aa6e10265 | Author: buckyballreaction | Log: Don't need boost:: prefix if I actually use the proper #include |
| 14:42:00 | | kodax has joined |
| 14:51:00 | | kodax Quit (Remote host closed the connection) |
| 15:12:00 | | watusimoto has joined |
| 15:43:00 | | kodax has joined |
| 16:25:00 | karamazovapy | watusimoto: what do you think of the star-rating mod posted on the forums? |
| 16:27:00 | raptor | i like it |
| 16:27:00 | raptor | but i haven't found a way to install plugins directly through the admin interface |
| 16:27:00 | karamazovapy | exactly |
| 16:27:00 | karamazovapy | watusimoto is the one who needs to do it |
| 16:32:00 | | kodax Quit (Quit: Sto andando via) |
| 16:34:00 | | raptor Quit (Remote host closed the connection) |
| 16:45:00 | watusimoto | I like it all except for that last part |
| 16:50:00 | karamazovapy | ...that you need to install it? |
| 16:56:00 | | raptor has joined |
| 16:56:00 | | ChanServ sets mode +o raptor |
| 16:57:00 | raptor | that watusimoto can't just let a lacky like us do it... :) |
| 17:03:00 | watusimoto | I wish I could! |
| 17:03:00 | watusimoto | really really do!!!!! |
| 17:05:00 | sam686 | maybe until bitfighter.org moves to different server? |
| 17:06:00 | | ShadowXLoner has joined |
| 17:08:00 | karamazovapy | maybe I can install it...I'm reading |
| 17:10:00 | watusimoto | except if you need to modify the any of the files outside the interface, you're stuck |
| 17:11:00 | karamazovapy | I'll do a quick read through and we'll see |
| 17:14:00 | karamazovapy | god, this is arduous |
| 17:15:00 | karamazovapy | Files to edit |
| 17:15:00 | karamazovapy | search.php, |
| 17:15:00 | karamazovapy | viewforum.php, |
| 17:15:00 | karamazovapy | viewtopic.php, |
| 17:15:00 | karamazovapy | adm/style/acp_forums.html, |
| 17:15:00 | karamazovapy | includes/constants.php, |
| 17:15:00 | karamazovapy | includes/acp/acp_forums.php, |
| 17:15:00 | karamazovapy | includes/acp/acp_styles.php, |
| 17:15:00 | karamazovapy | language/en/acp/styles.php, |
| 17:15:00 | karamazovapy | styles/prosilver/imageset/imageset.cfg, |
| 17:16:00 | karamazovapy | styles/prosilver/template/search_results.html, |
| 17:16:00 | karamazovapy | styles/prosilver/template/viewforum_body.html, |
| 17:16:00 | karamazovapy | styles/prosilver/template/viewtopic_body.html |
| 17:16:00 | karamazovapy | Included files |
| 17:16:00 | karamazovapy | root/language/en/acp/permissions_evaluation.php, |
| 17:16:00 | karamazovapy | root/language/en/mods/evaluation.php, |
| 17:16:00 | karamazovapy | root/mods/includes/acp/acp_forums.php, |
| 17:16:00 | karamazovapy | root/mods/includes/acp/acp_styles.php, |
| 17:16:00 | karamazovapy | root/mods/search.php, |
| 17:16:00 | karamazovapy | root/mods/viewforum.php, |
| 17:16:00 | raptor | crazy |
| 17:16:00 | karamazovapy | root/mods/viewtopic.php, |
| 17:16:00 | karamazovapy | root/install/install_evaluation_mod.php, |
| 17:16:00 | karamazovapy | root/install/uninstall_evaluation_mod.php, |
| 17:16:00 | karamazovapy | root/styles/prosilver/template/evaluation.html, |
| 17:16:00 | karamazovapy | root/styles/prosilver/imageset/evaluation_dark.gif, |
| 17:16:00 | karamazovapy | root/styles/prosilver/imageset/evaluation_half.gif, |
| 17:16:00 | karamazovapy | root/styles/prosilver/imageset/evaluation_light.gif |
| 17:16:00 | karamazovapy | it could be worse |
| 17:16:00 | karamazovapy | they say it's supposed to take ~23 minutes |
| 17:16:00 | watusimoto | right, so we're screwed |
| 17:16:00 | watusimoto | or rather I am because I have to do it |
| 17:17:00 | ShadowXLoner | And this is to do what? |
| 17:17:00 | watusimoto | screwed might be too strong a word |
| 17:17:00 | sam686 | too many files to edit, i bet it only works in one or 2 versions to phpbb, will it work on a version of phpbb that bitfighter.org is running? |
| 17:17:00 | karamazovapy | it's the forum mod that allows star-rating posts |
| 17:17:00 | ShadowXLoner | Oh, the like/dislike forum feature. I see. |
| 17:17:00 | karamazovapy | yeah |
| 17:18:00 | karamazovapy | this is why it hasn't happened yet - not because people dislike the idea |
| 17:19:00 | ShadowXLoner | But rather, because the coding behind it is rather dense. |
| 17:19:00 | sam686 | it could make updating phpbb harder with mods.. |
| 17:19:00 | karamazovapy | well the adds aren't hard |
| 17:19:00 | karamazovapy | the xml file they give to walk through the install makes it really easy |
| 17:20:00 | karamazovapy | hey wat - if you send me copies of those files, I can do the mod and send them back to you |
| 17:26:00 | watusimoto | ok, but later; I'm heading out really soon |
| 17:26:00 | raptor | the games doesn't crash for me anymore, and walls show up in-game again |
| 17:27:00 | raptor | editor segfault! |
| 17:27:00 | raptor | cool |
| 17:28:00 | karamazovapy | coolcoolcool. |
| 17:31:00 | raptor | ohhh... it's dying on trying to load walls, hehe |
| 17:31:00 | raptor | oh good, i don't think i introduced that bug.. |
| 17:48:00 | | watusimoto Quit (Ping timeout: 240 seconds) |
| 18:01:00 | | ShadowXLoner Quit (Quit: ShadowXLoner) |
| 21:00:00 | | watusimoto has joined |
| 21:46:00 | | raptor Quit (Remote host closed the connection) |
| 23:45:00 | | raptor has joined |
| 23:45:00 | | ChanServ sets mode +o raptor |