#bitfighter IRC Log

Index Search ←Prev date Next date→

IRC Log for 2026-05-11

Timestamps are in GMT/BST.

03:27:50BFLogBot Pull request #793 closed by eykamp | Title: Fix bugs in GeomUtils circle intersection and point-in-triangle | https://github.com/bitfighter/bitfighter/pull/793
03:27:51BFLogBot Repo: bitfighter | Commit: 398a41aa20 | Author: eykamp | Message: Fix bugs in GeomUtils circle intersection and point-in-triangle (#793) - Prevent division by zero in polygonCircleIntersect when handling degenerate edges. - Update Triangulate::InsideTriangle to support both CW and CCW winding orders. - Add unit tests for both fixes. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by
03:27:52BFLogBot : eykamp <1133323+eykamp@users.noreply.github.com>
15:39:05BFLogBot Pull request #794 closed by eykamp | Title: Fix string trimming truncation and inconsistent file I/O modes | https://github.com/bitfighter/bitfighter/pull/794
15:39:05BFLogBot Repo: bitfighter | Commit: e79e3b810e | Author: eykamp | Message: Fix string trimming truncation and inconsistent file I/O modes (#794) - Removed embedded null character from DEFAULT_TRIM_CHARS in zap/stringUtils.h to prevent truncation. - Added ios_base::binary to writeFile in zap/stringUtils.cpp for consistency with readFile and cross-platform reliability. - Added unit tests in bitfighter_test/TestStringUtils.cpp to verify the fixes. Identifi
15:39:07BFLogBot ed as an AI agent. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
15:42:34BFLogBot Repo: bitfighter | Commit: 27b6414496 | Author: google-labs-jules[bot] | Message: Fix string trimming bug and fortify geometry intersection logic This PR addresses two bugs identified in the codebase: 1. **Corrected `DEFAULT_TRIM_CHARS` truncation**: The macro previously contained an embedded null character which caused `std::string` objects to be truncated, omitting the vertical tab (`\v`). Updated to use the standard `\v` escape. 2. **Fortifi
15:42:35BFLogBot ed fragile `if` blocks in `GeomUtils.cpp`**: Added curly braces to `if (denom == 0.0)` blocks in `segmentsIntersect` and `findIntersection`. Previously, these were followed by commented-out code and a `return` statement, making them highly fragile to future edits. Included unit tests in `TestStringUtils.cpp` and `TestGeomUtils.cpp` to verify the fixes and ensure edge cases like vertical tabs and coincident segments are handled correctly. I am a
15:42:37BFLogBot n AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
15:42:38BFLogBot Pull request #795 opened by eykamp | Title: Fix string trimming bug and fortify geometry logic | https://github.com/bitfighter/bitfighter/pull/795
15:59:14BFLogBot Repo: bitfighter | Commit: 4319fd8c23 | Author: google-labs-jules[bot] | Message: Fix truncation bug in DEFAULT_TRIM_CHARS The `DEFAULT_TRIM_CHARS` macro was defined with an embedded null character (`\0`), which caused `std::string` objects initialized with it to be truncated. This resulted in the vertical tab character (`\v`) being omitted from the set of characters to be trimmed. Updated the macro to `" \n\r\t\v"`, which correctly includes th
15:59:16BFLogBot e vertical tab and avoids truncation. Added unit tests to verify that `trim()` and `isPositiveInteger()` now correctly handle vertical tabs. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
16:01:09BFLogBot Repo: bitfighter | Commit: 398a41aa20 | Author: eykamp | Message: Fix bugs in GeomUtils circle intersection and point-in-triangle (#793) - Prevent division by zero in polygonCircleIntersect when handling degenerate edges. - Update Triangulate::InsideTriangle to support both CW and CCW winding orders. - Add unit tests for both fixes. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by
16:01:10BFLogBot : eykamp <1133323+eykamp@users.noreply.github.com>
16:01:12BFLogBot Repo: bitfighter | Commit: e79e3b810e | Author: eykamp | Message: Fix string trimming truncation and inconsistent file I/O modes (#794) - Removed embedded null character from DEFAULT_TRIM_CHARS in zap/stringUtils.h to prevent truncation. - Added ios_base::binary to writeFile in zap/stringUtils.cpp for consistency with readFile and cross-platform reliability. - Added unit tests in bitfighter_test/TestStringUtils.cpp to verify the fixes. Identifi
16:01:13BFLogBot ed as an AI agent. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
16:01:15BFLogBot Repo: bitfighter | Commit: 8f58162025 | Author: eykamp | Message: Merge branch 'master' into fix-string-trim-and-geom-if-braces-1226004439219824873
16:01:20BFLogBot Pull request #795 closed by eykamp | Title: Fix string trimming bug and fortify geometry logic | https://github.com/bitfighter/bitfighter/pull/795
16:01:20BFLogBot Repo: bitfighter | Commit: 6b3a1ed412 | Author: eykamp | Message: Fix string trimming bug and fortify geometry logic (#795) * Fix string trimming bug and fortify geometry intersection logic This PR addresses two bugs identified in the codebase: 1. **Corrected `DEFAULT_TRIM_CHARS` truncation**: The macro previously contained an embedded null character which caused `std::string` objects to be truncated, omitting the vertical tab (`\v`). Updated
16:01:22BFLogBot to use the standard `\v` escape. 2. **Fortified fragile `if` blocks in `GeomUtils.cpp`**: Added curly braces to `if (denom == 0.0)` blocks in `segmentsIntersect` and `findIntersection`. Previously, these were followed by commented-out code and a `return` statement, making them highly fragile to future edits. Included unit tests in `TestStringUtils.cpp` and `TestGeomUtils.cpp` to verify the fixes and ensure edge cases like vertical tabs and coinc
16:01:23BFLogBot ident segments are handled correctly. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> * Fix truncation bug in DEFAULT_TRIM_CHARS The `DEFAULT_TRIM_CHARS` macro was defined with an embedded null character (`\0`), which caused `std::string` objects initialized with it to be truncated. This resulted in the vertical tab character (`\v`) being omitted from the set of characters to be trimmed. Updated the macro t
16:01:25BFLogBot o `" \n\r\t\v"`, which correctly includes the vertical tab and avoids truncation. Added unit tests to verify that `trim()` and `isPositiveInteger()` now correctly handle vertical tabs. I am an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
16:12:47BFLogBot Repo: bitfighter | Commit: ee5b15b0a8 | Author: google-labs-jules[bot] | Message: Fix bugs in stripZeros and ftos for zero values - Modified stripZeros in zap/stringUtils.cpp to ensure it returns "0" instead of an empty string, "-", "-0", or "+0" after stripping. - This ensures ftos returns "0" for very small values that round to zero or for negative zero. - Added comprehensive unit tests in bitfighter_test/TestStringUtils.cpp covering small pos
16:12:48BFLogBot itive/negative floats, explicit zero, and string inputs to stripZeros. This change was authored by an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>
16:12:50BFLogBot Pull request #796 opened by eykamp | Title: Fix bugs in stripZeros and ftos for zero values | https://github.com/bitfighter/bitfighter/pull/796
16:24:06BFLogBot Repo: bitfighter | Commit: fe6a2e22a2 | Author: eykamp | Message: Whitespace
16:33:44BFLogBot Repo: bitfighter | Commit: 6f3842356e | Author: eykamp | Message: Fix bugs in stripZeros and ftos for zero values (#796) * Fix bugs in stripZeros and ftos for zero values - Modified stripZeros in zap/stringUtils.cpp to ensure it returns "0" instead of an empty string, "-", "-0", or "+0" after stripping. - This ensures ftos returns "0" for very small values that round to zero or for negative zero. - Added comprehensive unit tests in bitfighter_t
16:33:44BFLogBot Pull request #796 closed by eykamp | Title: Fix bugs in stripZeros and ftos for zero values | https://github.com/bitfighter/bitfighter/pull/796
16:33:45BFLogBot est/TestStringUtils.cpp covering small positive/negative floats, explicit zero, and string inputs to stripZeros. This change was authored by an AI agent. Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com> * Whitespace --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: eykamp <1133323+eykamp@users.noreply.github.com>

Index Search ←Prev date Next date→

These logs were automatically created by BFLogBot on irc.freenode.net.